Make testing easier by adding a disable() method #40

LaurentEsc · 2015-10-22T09:48:20Z

This PR is related to issue #39 and is a suggestion to allow easy Validator mocking:

HoneypotValidator::shouldReceive('validateHoneytime')
    ->once()
    ->andReturn(true);

I have updated the documentation.

LaurentEsc · 2015-10-22T09:49:08Z

Moving the HoneypotFacade to another namespace is a breaking change, probably not the best idea ...

garygreen · 2015-10-22T09:56:43Z

To be honest I think at this point it would make sense to just get rid of the HoneypotValidator.php and move those 3 functions into Honeypot.php and update the tests. That way there isn't a need for two facades which seems overcomplicated imo.

garygreen · 2015-10-22T10:09:00Z

Also I think I would prefer to see something like Honeypot::enable() and Honeypot::disable() as oppose to the suggestion of mocking the validator functions.

LaurentEsc · 2015-10-22T10:43:53Z

Something like this ? I also like Honeypot::disable() for testing.

garygreen · 2015-10-22T10:46:38Z

src/Msurguy/Honeypot/HoneypotServiceProvider.php

@@ -49,8 +49,14 @@ public function boot()
            $translator = $app['translator'];

            // Add honeypot and honeytime custom validation rules
-            $validator->extend('honeypot', 'Msurguy\Honeypot\HoneypotValidator@validateHoneypot', $translator->get('honeypot::validation.honeypot'));
-            $validator->extend('honeytime', 'Msurguy\Honeypot\HoneypotValidator@validateHoneytime', $translator->get('honeypot::validation.honeytime'));
+            $validator->extend('honeypot', function($attribute, $value, $parameters) {


These don't need anonymous functions anymore. Just Msurguy\Honeypot\Honeypot@validateHoneypot

garygreen · 2015-10-22T10:49:55Z

Looks good to me. Tests pass?

garygreen · 2015-10-22T10:52:09Z

README.md

@@ -69,6 +69,28 @@ Please note that "honeytime" takes a parameter specifying number of seconds it s

 That's it! Enjoy getting less spam in your inbox. If you need stronger spam protection, consider using [Akismet](https://github.com/kenmoini/akismet) or [reCaptcha](https://github.com/dontspamagain/recaptcha)   

+## Testing


This needs updating

garygreen · 2015-10-22T10:52:50Z

Once updated I would suggest to squash the commits.

LaurentEsc · 2015-10-22T10:56:57Z

The problem with using Class@Method instead of a closure is that is creates a new instance to validate, so disable() doesn't work.

garygreen · 2015-10-22T11:04:12Z

Gotcha. I'm pretty sure the validator resolves the class thru the IOC so in theory if you did honeypot@method it should work.

LaurentEsc · 2015-10-22T11:05:17Z

Indeed, seems to work.

LaurentEsc · 2015-10-22T11:12:02Z

Tests didn't pass after I cloned:

Msurguy\Tests\HoneypotTest::test_get_honeypot_form_html
BadMethodCallException: Method Mockery_0_Msurguy_Honeypot_Honeypot::getFormHTML() does not exist on this mock object

garygreen · 2015-10-22T11:13:43Z

It should be generate, tests prob has been failing on that for a while.

…isable the validation

LaurentEsc · 2015-10-22T12:31:37Z

Documentation updated and commits squashed.

garygreen · 2015-10-22T12:36:33Z

Looks good. 👍

Make testing easier by adding a disable() method

garygreen reviewed Oct 22, 2015
View reviewed changes

Merge Honeypot and HoneypotValidator, add the possibility to enable/d…

953e042

…isable the validation

LaurentEsc changed the title ~~Make testing easier by adding a facade for the validator~~ Make testing easier by adding a disable() method Oct 22, 2015

msurguy added a commit that referenced this pull request Oct 22, 2015

Merge pull request #40 from LaurentEsc/master

dec0a28

Make testing easier by adding a disable() method

msurguy merged commit dec0a28 into msurguy:master Oct 22, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make testing easier by adding a disable() method #40

Make testing easier by adding a disable() method #40

LaurentEsc commented Oct 22, 2015

LaurentEsc commented Oct 22, 2015

garygreen commented Oct 22, 2015

garygreen commented Oct 22, 2015

LaurentEsc commented Oct 22, 2015

garygreen Oct 22, 2015

garygreen commented Oct 22, 2015

garygreen Oct 22, 2015

garygreen commented Oct 22, 2015

LaurentEsc commented Oct 22, 2015

garygreen commented Oct 22, 2015

LaurentEsc commented Oct 22, 2015

LaurentEsc commented Oct 22, 2015

garygreen commented Oct 22, 2015

LaurentEsc commented Oct 22, 2015

garygreen commented Oct 22, 2015

		@@ -69,6 +69,28 @@ Please note that "honeytime" takes a parameter specifying number of seconds it s

		That's it! Enjoy getting less spam in your inbox. If you need stronger spam protection, consider using [Akismet](https://github.com/kenmoini/akismet) or [reCaptcha](https://github.com/dontspamagain/recaptcha)

		## Testing

Make testing easier by adding a disable() method #40

Make testing easier by adding a disable() method #40

Conversation

LaurentEsc commented Oct 22, 2015

LaurentEsc commented Oct 22, 2015

garygreen commented Oct 22, 2015

garygreen commented Oct 22, 2015

LaurentEsc commented Oct 22, 2015

garygreen Oct 22, 2015

Choose a reason for hiding this comment

garygreen commented Oct 22, 2015

garygreen Oct 22, 2015

Choose a reason for hiding this comment

garygreen commented Oct 22, 2015

LaurentEsc commented Oct 22, 2015

garygreen commented Oct 22, 2015

LaurentEsc commented Oct 22, 2015

LaurentEsc commented Oct 22, 2015

garygreen commented Oct 22, 2015

LaurentEsc commented Oct 22, 2015

garygreen commented Oct 22, 2015